-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create badge component #2919
Merged
Merged
create badge component #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebby2105
requested review from
dudchakk,
ShadowOfTheSpace,
Mav-Ivan and
amoutens
December 1, 2024 21:28
ShadowOfTheSpace
requested changes
Dec 1, 2024
ShadowOfTheSpace
requested changes
Dec 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just renaming)
You can keep names of variables like in props without any conflict. It would be much better and readable
ShadowOfTheSpace
approved these changes
Dec 2, 2024
amoutens
approved these changes
Dec 3, 2024
SofiiaYevush
approved these changes
Dec 4, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Badge component #2861
Props:
variant
: Determines the badge style (sm
orlg
).color
: Supportsprimary
,success
, anderror
colors (default:primary
).isVisible
: Controls visibility of the badge (default:true
).badgeContent
: Numeric or textual content (applies tolg
variant).maxContent
: Specifies the maximum number to display, e.g., 99+ (default:10
).isZeroShown
: Toggles visibility of 0 content for thelg
variant (default:false
).Examples:
lg
'7
'sm
'success
'error
'lg
'success
'99
'lg
'7
'error
'lg
'0
'